Auto translate date format based on current i18n Locale #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gavin <gavinfreeborn@gmail.com>
Signed-off-by: Gavin <gavinfreeborn@gmail.com>
Deployment URLs ready for review. |
Gavinok
changed the title
loneil
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #593 the solution simply translates the i18n locale to the corresponding local supported by date-fns. I created a new type that is also used in the
LocaleSwitcherto ensure that when ever a new i18n locale is added the corresponding translation is also implemented.To better enforce this the conversion function will throw an exception. This is only necessary to handle cases where _dateFnsFormat is used outside of a vue component (which is likely never)